This revision was automatically updated to reflect the committed changes.
Closed by commit rGe8c78d8528a6: Allow getting template args for
ClassTemplateSpecializations (authored by anderslanglands, committed by
aaron.ballman).
Changed prior to commit:
https://reviews.llvm.org/D134416?vs=462392
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! I can fix up the minor nit with the release note formatting when I land
on your behalf.
Comment at: clang/docs/ReleaseNotes.rst:407-408
+ ``clang_Cursor
anderslanglands added a comment.
I ended up modifying c-index-test to print out the template arguments in the
same way it does for FunctionDecl, which ends up working all cases in the
existing test suite. The only other thing I added was a specific case in
index-templates.cpp to check whether i
anderslanglands updated this revision to Diff 462392.
anderslanglands marked 7 inline comments as done.
anderslanglands added a comment.
Add testing, address style notes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134416/new/
https://reviews.llvm
aaron.ballman added a comment.
Mostly nits from me (FWIW, we use `auto` when the type is explicitly spelled
out in the initialization and we don't usually use `else` after an
unconditional `return` as a matter of coding style.) In terms of the test
coverage, I would probably make a new test mod
anderslanglands updated this revision to Diff 462103.
anderslanglands added a comment.
Herald added a subscriber: arphaman.
Updating doc comments to reflect new functionality
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134416/new/
https://reviews
anderslanglands added reviewers: tbaeder, aaron.ballman.
anderslanglands added a comment.
Hello again, this generalizes the template argument functionality to operate on
cursor kinds other than functions.
I could use some help creating a test for this. On my previous path I was able
to just cop
anderslanglands created this revision.
Herald added a project: All.
anderslanglands requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Modifies clang_Cursor_getNumTemplateArguments() and friends to work on Struct,
Class and ClassTemplateParti
