Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

ClockMan added a comment. No, I don't have commits rights Repository: rL LLVM http://reviews.llvm.org/D13440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

On Fri, Oct 9, 2015 at 11:21 AM, Alexander Kornienko wrote: > alexfh accepted this revision. > alexfh added a comment. > This revision is now accepted and ready to land. > > Looks good. Do you have commit rights? If no, please have someone commit this > for you. I won't be able to help with this

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Do you have commit rights? If no, please have someone commit this for you. I won't be able to help with this soon, unfortunately. Repository: rL LLVM http://reviews.llvm.org/D1

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

ClockMan marked 3 inline comments as done. ClockMan added a comment. Repository: rL LLVM http://reviews.llvm.org/D13440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

alexfh added inline comments. Comment at: clang-tidy/rename_check.py:53 @@ +52,3 @@ + return newFileName + +def getListOfFiles(clang_tidy_path): ClockMan wrote: > Not sure what you mean... I meant that after that patch the module file name can be more complex. H

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

ClockMan updated this revision to Diff 36801. ClockMan added a comment. Corrected review issues. Repository: rL LLVM http://reviews.llvm.org/D13440 Files: clang-tidy/rename_check.py Index: clang-tidy/rename_check.py === --- /

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

ClockMan marked 5 inline comments as done. Comment at: clang-tidy/rename_check.py:53 @@ +52,3 @@ + return newFileName + +def getListOfFiles(clang_tidy_path): Not sure what you mean... Repository: rL LLVM http://reviews.llvm.org/D13440

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

alexfh added inline comments. Comment at: clang-tidy/rename_check.py:3 @@ +2,3 @@ +# +#===- add_new_check.py - clang-tidy check generator --*- python -*--===# +# Please update the script name and description in the comment. Comment at: c

Re: [PATCH] D13440: [clang-tidy] Python script for easy check rename

mgehre added a subscriber: mgehre. Comment at: clang-tidy/rename_check.py:39 @@ +38,3 @@ + if len(sys.argv) != 4: +print('Usage: rename_check.py , e.g.\n') +print('rename_check.py misc awesome-functions new-awesome-function\n') Should be ``` Usage: renam