[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

2022-09-22 Thread Michael Benfield via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ca599374187: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

2022-09-21 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. Thank you again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381 ___

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

2022-09-21 Thread Michael Benfield via Phabricator via cfe-commits
mbenfield updated this revision to Diff 462007. mbenfield added a comment. Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381 Files: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

2022-09-21 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. In D134381#3806929 , @mbenfield wrote: > I'll add a couple simple tests. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

2022-09-21 Thread Michael Benfield via Phabricator via cfe-commits
mbenfield added a comment. I'll add a couple simple tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

2022-09-21 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. This is OK, within existing practice, but it's unfortunate that we have no tests at all for any of these flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134381/new/ https://reviews.llvm.org/D134381 _

[PATCH] D134381: [clang-tidy] Add option WarnOnSizeOfPointerToAggregate.

2022-09-21 Thread Michael Benfield via Phabricator via cfe-commits
mbenfield created this revision. mbenfield added a reviewer: mizvekov. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. mbenfield requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This is now an opt