[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e25284dbc94: [AMDGPU] Emit module flag for all code object versions (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Gith

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

yaxunl added a comment. In D134355#3809471 , @b-sumner wrote: > In D134355#3809294 , @yaxunl wrote: > >> In D134355#3807435 , @cfang wrote: >> >>> LGTM >>> >>> Should the

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

b-sumner added a comment. In D134355#3809294 , @yaxunl wrote: > In D134355#3807435 , @cfang wrote: > >> LGTM >> >> Should the module flag name be amdgpu_code_object_version or >> amdhsa_code_object_version? > > G

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

yaxunl marked an inline comment as done. yaxunl added a comment. In D134355#3807435 , @cfang wrote: > LGTM > > Should the module flag name be amdgpu_code_object_version or > amdhsa_code_object_version? Good question. @b-sumner Does code object version

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

cfang accepted this revision. cfang added a comment. This revision is now accepted and ready to land. LGTM Should the module flag name be amdgpu_code_object_version or amdhsa_code_object_version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134355/new/ https://reviews.llvm.org/D13435

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:590-591 // times 100. -// ToDo: Enable module flag for all code object version when ROCm device -// library is ready. -if (getTarget().getTarget

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

arsenm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:590-591 // times 100. -// ToDo: Enable module flag for all code object version when ROCm device -// library is ready. -if (getTarget().getTargetOpts().CodeObjectVersion == TargetOptions

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

yaxunl created this revision. yaxunl added reviewers: b-sumner, cfang. Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D134355 Fi