This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG52d7ce0cc1a5: [HLSL] Allow SV_GroupIndex for lib profile.
(authored by python3kgae).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134326/new/
https://reviews.llvm.org/D134326
___
python3kgae updated this revision to Diff 461923.
python3kgae added a comment.
Update comments and format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134326/new/
https://reviews.llvm.org/D134326
Files:
clang/lib/Sema/SemaDeclAttr.cpp
clang/
beanz added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6901
+// FIXME: it is OK for a compute shader entry and pixel shader entry live
in
+// same HLSL file.
uint32_t Pipeline =
I think the underlying issue here is that some attrib
aaron.ballman added a comment.
This looks reasonable to me, but I leave the final sign-off to @beanz.
Comment at: clang/test/CodeGenHLSL/GlobalDestructors.hlsl:1
-// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -std=hlsl202x -S
-emit-llvm -disable-llvm-passes %s -o -
python3kgae created this revision.
python3kgae added reviewers: beanz, pow2clk, bogner, bob80905.
Herald added subscribers: Anastasia, arphaman.
Herald added a reviewer: aaron.ballman.
Herald added a project: All.
python3kgae requested review of this revision.
Herald added a project: clang.
Herald
