This revision was automatically updated to reflect the committed changes.
Closed by commit rL249300: Document a bug in loop-convert and fix one of its
subcases. (authored by angelgarcia).
Changed prior to commit:
http://reviews.llvm.org/D13431?vs=36500&id=36501#toc
http://reviews.llvm.org/D134
angelgarcia updated this revision to Diff 36500.
angelgarcia added a comment.
Use "UOP".
http://reviews.llvm.org/D13431
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
test/clang-tidy/modernize-loop-convert-basic.cpp
Index: test/clang-tidy/modernize-loop-convert-basic.cpp
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:529
@@ -527,1 +528,3 @@
Range = Paren->getSourceRange();
+ } else if (const auto *Uop = Parents[
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
Now that we prioritize copying trivial types over using const-references where
possible, I found some cases where, after the transformation, the loop was
using the address
