This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG21b03bf97061: [llvm] Handle dso_local_equivalent in
FunctionComparator (authored by leonardchan).
Repository:
rG LLVM Github Monorepo
CHANGES SIN
leonardchan added a comment.
Will wait until EOD before committing this unless others have more comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134300/new/
https://reviews.llvm.org/D134300
___
cf
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134300/new/
https://reviews.llvm.org/D134300
___
leonardchan added inline comments.
Comment at: llvm/test/Transforms/MergeFunc/dso_local_equivalent_merged.ll:1
+;; Check the cases involving dso_local_equivalent where we do expect functions
to be merged.
+; RUN: opt -S -mergefunc < %s | FileCheck %s
nikic wrote
leonardchan updated this revision to Diff 461686.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134300/new/
https://reviews.llvm.org/D134300
Files:
llvm/lib/Transforms/Utils/FunctionComparator.cpp
llvm/test/Transforms/MergeFunc/dso_local_equival
nikic added a comment.
Please drop the clang test and use update_test_checks.py for LLVM tests.
Comment at: llvm/test/Transforms/MergeFunc/dso_local_equivalent_merged.ll:1
+;; Check the cases involving dso_local_equivalent where we do expect functions
to be merged.
+; RUN: opt
leonardchan added a comment.
@phosek feel free to add who you think is appropriate for reviewing this.
This is a conservative comparison of dso_local_equivalents where two are the
same only if they point to the same underlying function. It could be argued
that a `dso_local_equivalent @func` cou
leonardchan created this revision.
leonardchan added a reviewer: phosek.
leonardchan added a project: LLVM.
Herald added subscribers: abrachet, hiraditya.
Herald added a project: All.
leonardchan requested review of this revision.
Herald added subscribers: cfe-commits, pcwang-thead.
Herald added a
