Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

2015-10-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249316: [VFS] Add working directories to every virtual file system. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13430?vs=36509&id=36515#toc Repository: rL LLVM http://review

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

2015-10-05 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Basic/VirtualFileSystem.cpp:1263-1265 @@ -957,5 +1262,5 @@ if (!F->useExternalName(UseExternalNames)) { // Provide a file wrapper that returns the

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

2015-10-05 Thread Benjamin Kramer via cfe-commits
bkramer marked 10 inline comments as done. Comment at: include/clang/Basic/VirtualFileSystem.h:286-288 @@ +285,5 @@ + } + std::error_code setCurrentWorkingDirectory(const Twine &Path) override { +WorkingDirectory = Path.str(); +return std::error_code(); + }

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

2015-10-05 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 36509. bkramer added a comment. Rebased and addressed review comments. http://reviews.llvm.org/D13430 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp unittests/Tooling/Rewriter

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

2015-10-05 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:286-288 @@ +285,5 @@ + } + std::error_code setCurrentWorkingDirectory(const Twine &Path) override { +WorkingDirectory = Path.str(); +return std::error_code(); + } Return e

[PATCH] D13430: [VFS] Add an in-memory file system implementation.

2015-10-05 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. This is a simple file system tree of memory buffers that can be filled by a client. In conjunction with an OverlayFS it can be used to make virtual files acc