[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin updated this revision to Diff 461598. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284/new/ https://reviews.llvm.org/D134284 Files: clang/test/lit.cfg.py Index: clang/test/lit.cfg.py ===

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin updated this revision to Diff 461589. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284/new/ https://reviews.llvm.org/D134284 Files: clang/test/lit.cfg.py Index: clang/test/lit.cfg.py

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

hubert.reinterpretcast added a comment. Instead of applying `OBJECT_MODE` to everything, maybe we can apply it only to the tool invocations via a LIT expansion? Something like `%llvm-nm` that expands (for AIX) to `OBJECT_MODE=any llvm-nm`? Would need to check that the LIT internal shell accepts

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

daltenty added a comment. > It looks to me like > https://github.com/llvm/llvm-project/blob/b982ba2a6e0f11340b4e75d1d4eba9ff62a81df7/clang/lib/Driver/Driver.cpp#L554 > should be modified to accept the OBJECT_MODE values you've implemented for > llvm-nm and llvm-ar. Otherwise, you'll never be ab

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin added a comment. In D134284#3802806 , @daltenty wrote: >> If OBJECT_MODE isn't an environment variable that clang uses, surely it >> should ignore it? > > The clang driver does in fact respect OBJECT_MODE on AIX, but I'm guessing it > doesn't

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

daltenty added a comment. > If OBJECT_MODE isn't an environment variable that clang uses, surely it > should ignore it? The clang driver does in fact respect OBJECT_MODE on AIX, but I'm guessing it doesn't accept the `any` setting (since it doesn't really make sense in that context). Reposit

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

jhenderson added a subscriber: jasonliu. jhenderson added a comment. In D134284#3802793 , @DiggerLin wrote: > In D134284#3802791 , @jhenderson > wrote: > >> In D134284#3802766

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin added a comment. In D134284#3802791 , @jhenderson wrote: > In D134284#3802766 , @DiggerLin > wrote: > >> In D134284#3802763 , @jhenderson >> wrote: >> >>> Wou

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

jhenderson added a comment. In D134284#3802766 , @DiggerLin wrote: > In D134284#3802763 , @jhenderson > wrote: > >> Wouldn't it be better to change the lit config to specify the `OBJECT_MODE` >> environment vari

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin added a comment. In D134284#3802763 , @jhenderson wrote: > Wouldn't it be better to change the lit config to specify the `OBJECT_MODE` > environment variable on AIX? I have tried it before, I added the following in clang/test/lit.cfg.py if 's

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

jhenderson added a comment. Wouldn't it be better to change the lit config to specify the `OBJECT_MODE` environment variable on AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284/new/ https://reviews.llvm.org/D134284 __

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin created this revision. DiggerLin added reviewers: jhenderson, daltenty, hubert.reinterpretcast. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. DiggerLin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c