tianshilei1992 added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9098
+ CombinedInfo.Types.push_back(
+ (Cap->capturesVariable() ? OMP_MAP_TO : OMP_MAP_LITERAL) |
+ OMP_MAP_TARGET_PARAM);
tianshilei1992 wrote:
> The v
tianshilei1992 added a comment.
Hi there, I'm trying to fix https://github.com/llvm/llvm-project/issues/59160.
The faulty case is basically like following:
cpp
void xoo() {
short a[10], b[10];
a[1] = 111;
b[1] = 111;
#pragma omp target data map(to : a[0 : 2], b[0 : 2]) use_devi
abhinavgaba accepted this revision.
abhinavgaba added a comment.
This revision is now accepted and ready to land.
Thanks, Jennifer. Looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134268/new/
https://reviews.llvm.org/D134268
__
jyu2 added inline comments.
Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:351
+// CHECK: omp_offload.failed:
+// CHECK-NEXT:call void
@{{__omp_offloading_[0-9a-z]+_[0-9a-z]+}}_main_l145(i32* [[TMP2]])
#[[ATTR5:[0-9]+]]
+// CHECK-NEXT:br label [[
abhinavgaba added inline comments.
Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:351
+// CHECK: omp_offload.failed:
+// CHECK-NEXT:call void
@{{__omp_offloading_[0-9a-z]+_[0-9a-z]+}}_main_l145(i32* [[TMP2]])
#[[ATTR5:[0-9]+]]
+// CHECK-NEXT:br l
