[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG30b676ac5f30: Don't crash when code completing `using enum ^Foo`. (authored by sammccall). Changed prior

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM to fix the crash. If @urnathan's changes happen to make this change obsolete, we could also revert consider reverting it afterwards. Comment at: clang/lib

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

sammccall added a comment. In D134243#3802457 , @urnathan wrote: > Might be mooted by fixing https://github.com/llvm/llvm-project/issues/57659, > which I am working on Great! Agree that larger changes around using-enum parsing would probably end up sol

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

urnathan added a comment. Might be mooted by fixing https://github.com/llvm/llvm-project/issues/57659, which I am working on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134243/new/ https://reviews.llvm.org/D134243 __

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

sammccall added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4591 Actions.CodeCompleteTag(getCurScope(), DeclSpec::TST_enum); +DS.SetTypeSpecError(); return; this is a bit unusual, usually parse() functions just stop after hitting CC,

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a subscriber: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/clangd/clangd/i