This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe782d9a4a49c: [clang] Fix a nullptr-access crash in
CheckTemplateArgument. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
hokein added inline comments.
Comment at: clang/lib/Sema/SemaTemplate.cpp:6960
+if (ParamType.isNull())
+ return ExprError();
// CheckNonTypeTemplateParameterType will produce a diagnostic if there's
adamcz wrote:
> So this can only happen when Resu
hokein updated this revision to Diff 461260.
hokein marked an inline comment as done.
hokein added a comment.
address review comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134180/new/
https://reviews.llvm.org/D134180
Files:
clang/lib/Sem
adamcz accepted this revision.
adamcz added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/SemaTemplate.cpp:6960
+if (ParamType.isNull())
+ return ExprError();
// CheckNonTypeTemplateParameterType will produce a diagnost
hokein created this revision.
hokein added reviewers: kadircet, adamcz.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang.
It is possible that we can pass a null ParamType to
CheckNonTypeTemplateParameter -- the ParamType var can be reset to a nul
