This revision was automatically updated to reflect the committed changes.
Closed by commit rG0dbc52a0ab3c: Add MC support of RISCV Zcd Extension
(authored by VincentWu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134177/new/
https://reviews.llvm.
VincentWu updated this revision to Diff 477475.
VincentWu added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134177/new/
https://reviews.llvm.org/D134177
Files:
clang/test/Preprocessor/riscv-target-features.c
llvm/lib/Suppor
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134177/new/
https://reviews.llvm.org/D134177
___
VincentWu updated this revision to Diff 463202.
VincentWu added a comment.
address comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134177/new/
https://reviews.llvm.org/D134177
Files:
clang/test/Preprocessor/riscv-target-features.c
llvm/l
craig.topper requested changes to this revision.
craig.topper added a comment.
This revision now requires changes to proceed.
Need to add Zcd command lines to compress-rv32d.s
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134177/new/
https://review
VincentWu updated this revision to Diff 462727.
VincentWu added a comment.
fix testcase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134177/new/
https://reviews.llvm.org/D134177
Files:
clang/test/Preprocessor/riscv-target-features.c
llvm/lib/
VincentWu updated this revision to Diff 462721.
VincentWu marked 3 inline comments as done.
VincentWu added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134177/new/
https://reviews.llvm.org/D134177
Files:
clang/test/
craig.topper added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCV.td:366
+ "'Zcd' (Compressed Double-Precision Floating-Point
Instructions)">;
+def HasStdExtZcd : Predicate<"Subtarget->hasStdExtZcf()">,
+ AssemblerPredica
craig.topper added inline comments.
Comment at: clang/test/Preprocessor/riscv-target-features.c:47
// CHECK-NOT: __riscv_zicbom
// CHECK-NOT: __riscv_zicboz
Need to update this too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
craig.topper added a comment.
Need to add Zcd command lines to compress-rv32d.s
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoC.td:881
let Predicates = [HasStdExtC, HasStdExtD] in {
def : CompressPat<(FLD FPR64:$rd, SP:$rs1, uimm9_lsb000:$imm),
CompressPa
VincentWu created this revision.
VincentWu added reviewers: kito-cheng, MaskRay, craig.topper, jrtc27,
HsiangKai, asb.
Herald added subscribers: sunshaoce, StephenFan, vkmr, frasercrmck, evandro,
luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,
PkmX, the_o, brucehoult
11 matches
Mail list logo