This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG368b6832de33: [Clang] Implement fix for DR2628 (authored by
royjacobson).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:/
royjacobson updated this revision to Diff 461352.
royjacobson added a comment.
rebase on main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134145/new/
https://reviews.llvm.org/D134145
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaTemp
royjacobson added inline comments.
Comment at: clang/test/CXX/drs/dr26xx.cpp:12
+void f() {
+ foo fooable; // expected-error {{call to deleted}}
+}
erichkeane wrote:
>
That does look much nicer, thanks! I qualified it with DR2628 because the DR
tests can get p
royjacobson updated this revision to Diff 461351.
royjacobson edited the summary of this revision.
royjacobson added a comment.
Add release note, slightly nicer test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134145/new/
https://reviews.llvm.org
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
This seems right to me, thanks!
I'm currently pushing to try to make our diagnostics 'check' lines more
readable... it doesn't gain a ton in this case, but more to try to push for
con
royjacobson created this revision.
Herald added a project: All.
royjacobson requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Implement suggested fix for DR2628. Coulnd't update the DR docs because there
hasn't been a new DRs index, but the
