[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

This revision was automatically updated to reflect the committed changes. Closed by commit rG069ecd0c6e2c: [ARM] Check target feature support for __builtin_arm_crc* (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134127/new/ htt

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

MaskRay added a comment. In D134127#3805748 , @dmgreen wrote: > Whether you do that here or in another patch, the change LGTM. Thanks:) I'll learn more about arm_acle.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Whether you do that here or in another patch, the change LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134127/new/ https://reviews.llvm.

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

dmgreen added a comment. The arm_acle.h header is shared across Arm and AArch64 - they use the same builtin names even if they are replicated to a certain degree across the backends. As this is used in both it would be good to fix them at the same time. It doesn't need to change the guards as D

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

MaskRay added a comment. In D134127#3798442 , @dmgreen wrote: > This looks like a subset of D133359 ? D133359 looks like it is for AArch64 and may change the diagnostic in a more aggre

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

dmgreen added reviewers: danielkiss, ilinpv. dmgreen added a comment. This looks like a subset of D133359 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134127/new/ https://reviews.llvm.org/D134127 __

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

MaskRay created this revision. MaskRay added reviewers: DavidSpickett, dmgreen, john.brawn. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `__builtin