Re: [PATCH] D13408: Skip NonNull sema checks in unevaluated contexts.

2015-10-08 Thread Eric Fiselier via cfe-commits
EricWF updated the summary for this revision. EricWF updated this revision to Diff 36910. http://reviews.llvm.org/D13408 Files: lib/Sema/SemaChecking.cpp test/Sema/non-null-warning.c Index: test/Sema/non-null-warning.c === --- t

Re: [PATCH] D13408: Skip NonNull sema checks in unevaluated contexts.

2015-10-05 Thread Eric Fiselier via cfe-commits
EricWF added a comment. `DiagRuntimeBehavior` seems like a better way to do this. I'll commit that change. http://reviews.llvm.org/D13408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D13408: Skip NonNull sema checks in unevaluated contexts.

2015-10-05 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This seems reasonable. I wonder if it might be better to also suppress warnings for dynamically-unreachable code (you can do this by changing the `Diag` calls inside `CheckNonNullArguments` t

[PATCH] D13408: Skip NonNull sema checks in unevaluated contexts.

2015-10-03 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added reviewers: rsmith, majnemer. EricWF added subscribers: cfe-commits, mclow.lists. Currently when a function annotated with __attribute__((nonnull)) is called in an unevaluated context with a null argument a -Wnonnull warning is emitted. This warning seem