This revision was automatically updated to reflect the committed changes.
Closed by commit rG84f1df8aacd0: [clang][Interp] Properly destruct allocated
Records (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D134054?vs=460813&id=463839#toc
Repository:
rG LLVM Github M
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM as well (modulo Erich's comments).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134054/new/
https://reviews.llvm.org/D134054
___
erichkeane accepted this revision.
erichkeane added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/AST/Interp/Program.h:48
+// here manually so they are properly freeing their resources.
+for (auto It : Records)
+ It.second->~
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Program.h:48
+// here manually so they are properly freeing their resources.
+for (auto It : Records)
+ It.second->~Record();
erichkeane wrote:
> I SUSPECT that by a reading of our rules
erichkeane added a comment.
Other than the pedantry above, LGTM.
Comment at: clang/lib/AST/Interp/Program.h:48
+// here manually so they are properly freeing their resources.
+for (auto It : Records)
+ It.second->~Record();
I SUSPECT that by a read
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As discussed with @aaron.ballman on IRC.
This reve