[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

owenpan added a comment. See D150057 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 ___ cfe-commits mailing list cfe-commit

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar added a comment. I retract my objection. I forgot that from clang-format's perspective, `#else` blocks in separate functions have the same indent and nesting level, and thus the same "scope", so the alignment issues may persist there. You will see misalignment in `#else` blocks

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar added a comment. After reviewing the GitHub issue, it looks like the IndentAndNestingLevel is sticky over the entire scope for `#else` blocks, so the regression only occurs within `#else` blocks in the same scope. The bug I fixed affected alignment in all `#else` blocks, regard

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

owenpan added a subscriber: rymiel. owenpan added a comment. Herald added a reviewer: rymiel. I'll revert this patch due to the regression https://github.com/llvm/llvm-project/issues/61498 unless any of you (and @rymiel ) objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0779756a0c4: [clang-format] Fix alignment in #else preprocessor blocks (authored by mitchell <56368743+mitchell-stel...@users.noreply.github.com>).

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar updated this revision to Diff 461979. mitchell-stellar added a comment. Do not limit columns and added nested test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 Files: clang/lib/Format/WhitespaceManager.cpp clang/u

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

MyDeveloperDay added a comment. Should we test nested if/else/endif CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good, please wait for other reviewers. Comment at: clang/unittests/Format/FormatTest.cpp:5747 +TEST_F(FormatTest, FormatAlignInsidePreprocessorE

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar updated this revision to Diff 460890. mitchell-stellar added a comment. Added context and use verifyFormat(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 Files: clang/lib/Format/WhitespaceManager.cpp clang/unittests/Fo

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

HazardyKnusperkeks added a comment. Please reupload the diff with the context. Comment at: clang/unittests/Format/FormatTest.cpp:5785 + "}"; +EXPECT_EQ(Expected, format(ToFormat, Style)); +EXPECT_EQ(Expected, format(Expected, Style)); -

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

mitchell-stellar created this revision. mitchell-stellar added reviewers: HazardyKnusperkeks, curdeius, MyDeveloperDay. mitchell-stellar added a project: clang-format. Herald added a project: All. mitchell-stellar requested review of this revision. Herald added a project: clang. Fixes https://gith