[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e637fcb2550: [clang][deps] Make sure ScanInstance outlives collector (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Good catch, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/ https://reviews.llvm.org/D133988 __

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

jansvoboda11 updated this revision to Diff 460552. jansvoboda11 added a comment. Replace `std::shared_ptr` by `Optional` stored on `DependencyScanningAction`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/ https://reviews.llvm.org/D13398

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

jansvoboda11 added a comment. Another option would be to store `ScanInstance` as member of `DependencyScanningAction`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/ https://reviews.llvm.org/D133988

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ScanInstance` is a local variable in `DependencyScanningAction::