[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

2022-09-16 Thread Bartłomiej Cieślar via Phabricator via cfe-commits
barcisz updated this revision to Diff 460743. barcisz added a comment. Herald added a subscriber: aheejin. documentation for the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133956/new/ https://reviews.llvm.org/D133956 Files: .clang-tidy

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

2022-09-15 Thread Bartłomiej Cieślar via Phabricator via cfe-commits
barcisz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cuda/unsafe-kernel-call-macro-handler.cu:53 + } + auto err = cudaGetLastError(); + tra wrote: > barcisz wrote: > > tra wrote: > > > Just curious -- is it sufficient to just c

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

2022-09-15 Thread Bartłomiej Cieślar via Phabricator via cfe-commits
barcisz updated this revision to Diff 460550. barcisz added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133956/new/ https://reviews.llvm.org/D133956 Files: clang-tools-extra/clang-tidy/cuda/CMakeLists.txt clang-tools-extra/

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

2022-09-15 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. > The intention with this check is to work a lot in tandem with the one in > D133804 , which therefore prevents most > such cases. > Thus, the check is optimized for lowering false positives during static > checking and for a practice lowe