This revision was automatically updated to reflect the committed changes.
Closed by commit rGbc14ed7de0f1: Add clang_CXXMethod_isDeleted function
(authored by anderslanglands, committed by aaron.ballman).
Changed prior to commit:
https://reviews.llvm.org/D133924?vs=460865&id=461900#toc
Reposit
anderslanglands added a comment.
Yes it's probably safest if someone commits on my behalf, unless someone's got
time to walk me through it. Just use Anders Langlands anderslanga...@gmail.com
for attribution please.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revi
anderslanglands updated this revision to Diff 460865.
anderslanglands added a comment.
Adding missing backtick
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133924/new/
https://reviews.llvm.org/D133924
Files:
clang/bindings/python/clang/cindex.p
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from the one minor nit.
Do you need someone to commit on your behalf? If so, what name and email
address would you like used for patch attribution?
anderslanglands added a comment.
OK that should all be good now. Thanks for your patience, it's my first time
doing all this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133924/new/
https://reviews.llvm.org/D133924
_
anderslanglands updated this revision to Diff 460672.
anderslanglands added a comment.
Adding in the dyn_cast_is_present change I missed on the previous one
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133924/new/
https://reviews.llvm.org/D133924
tbaeder added inline comments.
Comment at: clang/docs/ReleaseNotes.rst:323
+- Introduced the new function `clang_CXXMethod_isDeleted`, which queries
+ whether the method is declared `= delete.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
anderslanglands updated this revision to Diff 460663.
anderslanglands added a comment.
squashing all commits into one to hopefully fix the revision
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133924/new/
https://reviews.llvm.org/D133924
Files:
tbaeder added a comment.
Looks like the new version you uploaded is //only// the changes to the last
version. You need to merge that into your previous commit and upload a patch of
that. (e.g. using `git rebase -i` or even just `git commit --amend`).
Repository:
rG LLVM Github Monorepo
CHAN
anderslanglands updated this revision to Diff 460549.
anderslanglands added a comment.
Updating based on review
- Add new function to release notes
- Fix failing test and add a new test specifically for this function
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://rev
aaron.ballman added a comment.
Thanks for this! Can you add a release note to clang/docs/ReleaseNotes.rst and
some test coverage for the change to clang/test/Index for the change? Also, it
looks like precommit CI found a relevant failure that needs to be fixed:
TEST 'Clan
tbaeder added inline comments.
Comment at: clang/tools/libclang/CIndex.cpp:8870
+ const CXXMethodDecl *Method =
+ D ? dyn_cast_or_null(D->getAsFunction()) : nullptr;
+ return (Method && Method->isDeleted()) ? 1 : 0;
Repository:
rG LLVM Github Monorepo
anderslanglands created this revision.
Herald added a subscriber: arphaman.
Herald added a project: All.
anderslanglands requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D133924
13 matches
Mail list logo
