[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks for confirming. I have pushed a patch at: https://reviews.llvm.org/D136803 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 ___

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. I can confirm that applying the following: diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp index a8585a6d84ad..f07c40cb6c5d 100644 --- a/clang/lib/AST/ASTContext.cpp +++ b/clang/lib/AST/ASTContext.cpp @@ -6774,7 +6774,7 @@ ASTContext::g

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. I think there is a high chance that the bug that caused richard's patch to be reverted, was actually fixed afterwards by https://github.com/llvm/llvm-project/commit/acb767f5cda59302aa9100afcf6133d66779d42c So I will try to land that one again, and then I will try to la

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. This is surprisingly not from a bug in this patch. So `getCanonicalTemplateArgument` is broken for the types of declarations. This bug was supposedly fixed by zygoloid (https://github.com/llvm/llvm-project/commit/849c60541b630ddf8cabf9179fa771b3f4207) But then was reve

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks. Reduced to: void foo(); template void bar() {} template void bar<>(); template void bar(); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. Reduced testcase: cc1 command line: `clang-16 -cc1 -triple x86_64-unknown-linux-gnu -emit-obj -o Unified_cpp_editor_txmgr0.o -x c++-cpp-output Unified_cpp_editor_txmgr0.ii` source file content: class nsCycleCollectionParticipant; class nsCycleCollectingAutoRefCnt;

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3884904 , @glandium wrote: > I'm running it through creduce (as well as the one for D136564 > . It's going to take a little while. Thank > you for the revert. That's very helpful, t

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. I'm running it through creduce (as well as the one for D136564 . It's going to take a little while. Thank you for the revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ ht

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3884468 , @glandium wrote: > This broke building Firefox with: Thanks for reporting. Do you have preprocessed source + cc1 flags to reproduce it, so I can have a look? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. This broke building Firefox with: In file included from Unified_cpp_editor_txmgr0.cpp:2: In file included from /tmp/gecko/editor/txmgr/TransactionItem.cpp:6: In file included from /tmp/gecko/editor/txmgr/TransactionItem.h:9: In file included from /tmp/gecko/obj-

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG11ce78940b4c: [clang] Changes to produce sugared converted template arguments (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/ne

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov updated this revision to Diff 470645. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h clang/lib/Sema/SemaLo

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3882350 , @erichkeane wrote: > The test changes are a little bizarre, are there any better tests you can > write that shows this behavior? > > Also, at the 'end' of this patch set, we should make sure we have a detai

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Sema/Sema.h:8285 + TemplateArgument &SugaredConverted, + Templ

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added inline comments. Comment at: clang/include/clang/Sema/Sema.h:8285 + TemplateArgument &SugaredConverted, + TemplateArgument &CanonicalConverted, + CheckTemplateArgu

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

erichkeane added a comment. The test changes are a little bizarre, are there any better tests you can write that shows this behavior? Also, at the 'end' of this patch set, we should make sure we have a detailed release note. Comment at: clang/include/clang/Sema/Sema.h:8285 +

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

erichkeane added a comment. In D133874#3882101 , @mizvekov wrote: > @erichkeane since you reviewed and approved 5 patches that depend on this > one, can you also have a look at this please? > > Thanks! Thanks for the ping, I missed this is in the massiv

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a reviewer: erichkeane. mizvekov added a subscriber: erichkeane. mizvekov added a comment. @erichkeane since you reviewed and approved 5 patches that depend on this one, can you also have a look at this please? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov updated this revision to Diff 470346. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h clang/lib/Sema/SemaLo

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov retitled this revision from "[clang] Implement sugar retention for converted template arguments" to "[clang] Changes to produce sugared converted template arguments". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470006. Repository: rG LLVM Githu