[PATCH] D133753: [clang][Interp] WIP: Array fillers

2022-10-13 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.h:83 + /// that have an array filler. + const InterpSize NumFullElems = 0; + const Expr *ArrayFiller = nullptr; How about `NumElemsWithFiller`? Comment at: clang/li

[PATCH] D133753: [clang][Interp] WIP: Array fillers

2022-09-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 460059. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133753/new/ https://reviews.llvm.org/D133753 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Descriptor

[PATCH] D133753: [clang][Interp] WIP: Array fillers

2022-09-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:54 + assert(Stk.empty()); + return true; } The additional asserts I inserted here could be in another patch. However, I added them because I ran into a peculiar problem: when creating

[PATCH] D133753: [clang][Interp] WIP: Array fillers

2022-09-13 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: erichkeane, aaron.ballman, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Uploading this now to get some early feedback on th