[PATCH] D133725: Searching for tokens including comments

2022-09-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Ah, thank you for the extra description, that helped a lot. The changes LGTM, though you should hold off on landing them until we're sure the clang-tidy changes are going in. R

[PATCH] D133725: Searching for tokens including comments

2022-09-15 Thread Bartłomiej Cieślar via Phabricator via cfe-commits
barcisz added a comment. In D133725#3792787 , @aaron.ballman wrote: > Can you help me understand the expected use for these change? Changed the description to answer your question - it's a prerequisite to D133942 and

[PATCH] D133725: Searching for tokens including comments

2022-09-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Can you help me understand the expected use for these change? Comment at: clang/lib/Lex/Lexer.cpp:1278 - const char *TokenBegin = File.data() + LocInfo.second; + const char *const TokenBegin = File.data() + LocInfo.second; D

[PATCH] D133725: Searching for tokens including comments

2022-09-12 Thread Bartłomiej Cieślar via Phabricator via cfe-commits
barcisz created this revision. Herald added a project: All. barcisz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a small diff that adds an optional argument to the Lexer::findNextToken that allows for searching for the token whi