[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

2022-10-30 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. See D137052 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133647/new/ https://reviews.llvm.org/D133647 ___ cfe-commits mailing list cfe-commit

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

2022-10-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This seems to have regressed comment alignment on unrelated directives: #if 0 #endif #if X int something_fairly_long; // Align here please #endif // Should be aligned These comments were aligned before this patch, but are no longer. I

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

2022-09-16 Thread sstwcw via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2183fe2160fb: [clang-format] Parse the else part of `#if 0` (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D133647?vs=459305&id=460729#toc Repository: rG LLVM Github Monorepo

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

2022-09-13 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1128 +// If the first branch is unreachable, set the BranchIndex to 1. This way +// the next branch it

[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

2022-09-10 Thread sstwcw via Phabricator via cfe-commits
sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issu