[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25370 + "#if 0\n" + " if (a) {\n" + "#else\n" sstwcw wrote: > Can you confirm that there is supposed to be only one space here while there

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25370 + "#if 0\n" + " if (a) {\n" + "#else\n" Can you confirm that there is supposed to be only one space here while there are two in the ne

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG5889ed83a0ff: [clang-format] Don't insert braces for loops with a null statement (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133635/

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

owenpan added a comment. In D133635#378 , @MyDeveloperDay wrote: > Can't tell you how much I love this `InsertBraces` feature @owenpan, I work > for a team (with a large code base) that uses them all the time, and we are > catching missing braces

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

MyDeveloperDay added a comment. Can't tell you how much I love this `InsertBraces` feature @ownpan, I work for a team (with a large code base) that uses them all the time, and we are catching missing braces in decade-old code! Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a work