[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2023-05-16 Thread Amir Ayupov via Phabricator via cfe-commits
Amir abandoned this revision. Amir added a comment. Herald added a subscriber: ekilmer. No longer needed for Clang-BOLT. @thevinster – feel free to commandeer if it fits your needs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https:/

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-11-26 Thread Amir Ayupov via Phabricator via cfe-commits
Amir added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:11 +macro(clang_bootstrap_add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" +"DEPENDS;TABLEGEN;CMAKE_ARGS;BUILD_TOOL_ARGS" thevinster wrote: > Were you p

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-11-22 Thread Vincent Lee via Phabricator via cfe-commits
thevinster added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:11 +macro(clang_bootstrap_add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" +"DEPENDS;TABLEGEN;CMAKE_ARGS;BUILD_TOOL_ARGS" Were you planning to als

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-11-15 Thread Amir Ayupov via Phabricator via cfe-commits
Amir marked an inline comment as done. Amir added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:10 +# Optional arguments to pass to the build tool +macro(clang_Bootstrap_Add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" ---

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-11-15 Thread Amir Ayupov via Phabricator via cfe-commits
Amir updated this revision to Diff 475505. Amir added a comment. s/clang_Bootstrap_Add/clang_bootstrap_add Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt clang/cmake/modul

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-11-15 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:10 +# Optional arguments to pass to the build tool +macro(clang_Bootstrap_Add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" We usually use lowercase na

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-11-14 Thread Amir Ayupov via Phabricator via cfe-commits
Amir updated this revision to Diff 475309. Amir added a comment. Move out toolchain tools back into CMAKE_ARGS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt clang/cmake/m

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-09-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/CMakeLists.txt:912-926 +TABLEGEN +-DLLVM_TABLEGEN=${LLVM_RUNTIME_OUTPUT_INTDIR}/llvm-tblgen +-DCLANG_TABLEGEN=${LLVM_RUNTIME_OUTPUT_INTDIR}/clang-tblgen +LINKER -DCMAKE_LINKER=${LLVM_RUNTIME_OUTPUT_I

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-09-12 Thread Amir Ayupov via Phabricator via cfe-commits
Amir updated this revision to Diff 459589. Amir added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt clang/cmake/modules/ClangBootstrap.cmake Index: cla

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

2022-09-09 Thread Amir Ayupov via Phabricator via cfe-commits
Amir created this revision. Amir added reviewers: phosek, MaskRay. Herald added subscribers: StephenFan, mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commit