[PATCH] D133570: #57353 on github

2022-09-09 Thread Ofek Shochat via Phabricator via cfe-commits
OfekShochat added a comment. hello! thank you so much, Ill do that now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D133570 ___ cfe-commits mailing list cfe

[PATCH] D133570: #57353 on github

2022-09-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. In D133570#3779856 , @OfekShochat wrote: > its my first time contributing. this is probably very bad and goes against a > lot of guidelines, but I wouldnt resist to fix th

[PATCH] D133570: #57353 on github

2022-09-09 Thread Ofek Shochat via Phabricator via cfe-commits
OfekShochat added a comment. trying to fix the problem. probably going to split this into two patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D133570 ___ cfe-co

[PATCH] D133570: #57353 on github

2022-09-09 Thread Ofek Shochat via Phabricator via cfe-commits
OfekShochat added a comment. its my first time contributing. this is probably very bad and goes against a lot of guidelines, but I wouldnt resist to fix them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D13357