[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 461561. barcisz added a comment. Inlined definition of size_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools-extra/clang-tidy/CMakeLists.txt c

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/stddef.h:12 + +using size_t = long long unsigned; + barcisz wrote: > njames93 wrote: > > If this is all the file is used for, and it's only used for this o

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/stddef.h:12 + +using size_t = long long unsigned; + njames93 wrote: > If this is all the file is used for, and it's only used for this one test > file, can prob

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/stddef.h:12 + +using size_t = long long unsigned; + If this is all the file is used for, and it's only used for this one test file, can probably remove this he

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460520. barcisz added a comment. moved size_t definition to an stddef.h stub Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools-extra/clang-tidy/CMa

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460519. barcisz added a comment. Dummy definition for size_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools-extra/clang-tidy/CMakeLists.txt cl

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460374. barcisz marked 2 inline comments as done. barcisz added a comment. Changes suggested by njames93 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clan

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

njames93 added a comment. What's with the .keep files. Will lit or sphinx fail if the cuda directory doesn't exist, if not I'd be happier removing them(they'd get removed once the first cuda check lands anyway). Comment at: clang-tools-extra/clang-tidy/cuda/CudaTidyModule.cpp

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460070. barcisz added a comment. Herald added a subscriber: arphaman. Common documentation for cuda checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: cl

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460027. barcisz added a comment. Better explanation of cuda-related flags in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools-extra/clang-ti

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz added a comment. @tschuett does it look alright now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz added inline comments. Comment at: clang-tools-extra/clang-tidy/cuda/CudaTidyModule.cpp:25 + +// Register the GoogleTidyModule using this statically initialized variable. +static ClangTidyModuleRegistry::Add tschuett wrote: > Is Google a copy and paste er

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 458504. barcisz added a comment. removed duplication of '.cu' in the lit config for clang-tidy tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-to

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 458502. barcisz added a comment. Fixed a copy-paste error with Google->Cuda in CudaTidyModule.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

ivanmurashko added inline comments. Comment at: clang-tools-extra/test/lit.cfg.py:19 # suffixes: A list of file extensions to treat as test files. -config.suffixes = ['.c', '.cpp', '.hpp', '.m', '.mm', '.cu', '.ll', '.cl', '.s', +config.suffixes = ['.c', '.cpp', '.cu', '.hpp',

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

tschuett added inline comments. Comment at: clang-tools-extra/clang-tidy/cuda/CudaTidyModule.cpp:25 + +// Register the GoogleTidyModule using this statically initialized variable. +static ClangTidyModuleRegistry::Add Is Google a copy and paste error? ==

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz created this revision. Herald added subscribers: mattd, carlosgalvezp, yaxunl, mgorny. Herald added a project: All. barcisz requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Signed-off-by: bcieslar Repository: rG LLVM