This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rG5f7f4846e826: [clangd] Fix non-idempotent cases of
canonicalRenameDecl() (authored by sammccall).
Change
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:1521
R"cpp(
template class Foo { virtual void [[m]](); };
class Bar : Foo { void [[^m]]() override; };
---
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM to unbreak clangd. Agree that a more thorough look at this is needed.
Maybe add a bug to track this?
Comment at: clang-tools-extra/clangd/unittests/RenameT
sammccall created this revision.
sammccall added reviewers: ilya-biryukov, tom-anders.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang-tools-extra.
