[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d149d17f069: [clang-tidy] Fix crashes on `if consteval` in readability checks (authored by rymiel). Changed prior to commit: https://reviews.llvm.org/D133413?vs=464176&id=465291#toc Repository: rG L

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

njames93 accepted this revision. njames93 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133413/new/ https://reviews.llvm.org/D133413 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel updated this revision to Diff 464176. rymiel added a comment. Extra consteval checks in SimplifyBooleanExprCheck Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133413/new/ https://reviews.llvm.org/D133413 Files: clang-tools-extra/clang-tid

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel marked 2 inline comments as done. rymiel added a comment. Thank you for pointing those out, I was indeed able to cause crashes from those locations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133413/new/ https://reviews.llvm.org/D133413

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:471 auto *If = cast(*First); if (!If->hasInitStorage() && !If->hasVarStorage()) { ExprAndBool ThenReturnBool = Probably

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel updated this revision to Diff 464142. rymiel edited the summary of this revision. rymiel added a comment. Add release note Thank you, Aaron! Is the note I've added okay? I didn't expect to need to add a note to a bugfix, but I haven't written a release note before at all regardless. And

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note for the fix. Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel added a comment. Ping? This is fixing a segmentation fault. Please let me know if there are other people I should add as reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133413/new/ https://reviews.llvm.org/D133413 _

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel added a comment. Note for reviewing: - The C++ standard, from what I could tell, seems to imply the the else clause of a consteval if clause could be written without braces, however it seems that both GCC and Clang don't allow for this, so both clauses of constexpr if statements should

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel created this revision. rymiel added reviewers: njames93, LegalizeAdulthood, aaron.ballman, gribozavr2. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscrib