[PATCH] D133405: [Linux] Hack around Linux/sparc

glaubitz added a comment. In D133405#3782137 , @nikic wrote: > In D133405#3782136 , @glaubitz > wrote: > >> In D133405#3782092 , @nikic wrote: >> I've been using thi

[PATCH] D133405: [Linux] Hack around Linux/sparc

nikic added a comment. In D133405#3782136 , @glaubitz wrote: > In D133405#3782092 , @nikic wrote: > >>> I've been using this hack to work around the Linux/sparc64 compile failure >>> described in Issue #47994, es

[PATCH] D133405: [Linux] Hack around Linux/sparc

glaubitz added a comment. In D133405#3782092 , @nikic wrote: >> I've been using this hack to work around the Linux/sparc64 compile failure >> described in Issue #47994, especially since the underlying glibc PR >> build/27558 doesn't seem to be making pr

[PATCH] D133405: [Linux] Hack around Linux/sparc

nikic added a comment. > I've been using this hack to work around the Linux/sparc64 compile failure > described in Issue #47994, especially since the underlying glibc PR > build/27558 doesn't seem to be making progress and some fix is required to > have LLVM build on sparc64-unknown-linux-gnu a

[PATCH] D133405: [Linux] Hack around Linux/sparc

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e56821bac02: [Linux] Hack around Linux/sparc (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133405/new/ https://review

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro updated this revision to Diff 459017. ro added a comment. Add comment, tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133405/new/ https://reviews.llvm.org/D133405 Files: clang/lib/Basic/Targets/OSTargets.h clang/test/Preprocessor/init

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro added a comment. In D133405#3779190 , @MaskRay wrote: > So, sparc64 gcc does seem to define the macro by default. (I am using Debian > testing and can't tell whether it's distro setting or upstream default) > ¯\_(ツ)_/¯ > > % sparc64-linux-gnu-gcc -

[PATCH] D133405: [Linux] Hack around Linux/sparc

MaskRay accepted this revision. MaskRay added a subscriber: zatrazz. MaskRay added a comment. This revision is now accepted and ready to land. So, sparc64 gcc does seem to define the macro by default. ¯\_(ツ)_/¯ % sparc64-linux-gnu-gcc -E -dM -xc /dev/null -nostdinc | grep NO_INLINE #define __

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro added a comment. In D133405#3776096 , @MaskRay wrote: > It's not a compiler's job to define this workaround... Yes and no: GCC successfully does it via its `fixincludes` mechanism. Unfortunately, LLVM doesn't provide something similar and doesn't ev

[PATCH] D133405: [Linux] Hack around Linux/sparc

MaskRay added a comment. It's not a compiler's job to define this workaround... If a platform want to provide a built-in macro, you can use https://clang.llvm.org/docs/UsersManual.html#configuration-files and add `-D__NO_INLINE__` there. To avoid magic behaviors, `${triple}-clang` loads `${trip

[PATCH] D133405: [Linux] Hack around Linux/sparc

glaubitz added a comment. Thanks, this is definitely very useful. I have pinged glibc upstream and asked them about the progress about this change. Let' see. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133405/new/ https://reviews.llvm.org/D13340

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro created this revision. ro added reviewers: glaubitz, MaskRay. Herald added subscribers: StephenFan, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I've been using this hack to wor