Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-06 Thread Manuel Klimek via cfe-commits
klimek closed this revision. klimek added a comment. Submitted as r249391. http://reviews.llvm.org/D13318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-05 Thread Luke Zarko via cfe-commits
zarko updated this revision to Diff 36529. zarko added a comment. Copy a dependency from a test Makefile to its CMakeLists. http://reviews.llvm.org/D13318 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp unittests/Tooling/CMakeLists.txt unittests/Tooling/ToolingTest.cpp I

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-05 Thread Luke Zarko via cfe-commits
zarko added a comment. I'd tested with the Makefile; it looks like CMakeLists for the unit tests isn't linking `${LLVM_TARGETS_TO_BUILD}`. I've updated the diff. http://reviews.llvm.org/D13318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-05 Thread Manuel Klimek via cfe-commits
klimek added a comment. Did you test this with cmake? I get undef reference functions when linking ToolingTest... http://reviews.llvm.org/D13318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-01 Thread Luke Zarko via cfe-commits
zarko marked an inline comment as done. zarko added a comment. Thanks; would someone with commit access land this? echristo: for a more concrete example, imagine a source code indexer that collects up dependencies. This is a Clang tool that gets called by the build system for each translation u

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-01 Thread Luke Zarko via cfe-commits
zarko updated this revision to Diff 36266. zarko added a comment. Address comment comments. http://reviews.llvm.org/D13318 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp unittests/Tooling/ToolingTest.cpp Index: unittests/Tooling/ToolingTest.cpp ===

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-01 Thread Eric Christopher via cfe-commits
echristo added a comment. BTW as Manuel is happy it's fine with me. Still curious though. http://reviews.llvm.org/D13318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-01 Thread Manuel Klimek via cfe-commits
klimek added a comment. In http://reviews.llvm.org/D13318#257091, @echristo wrote: > This seems a little odd, could you explain in a bit more detail? Me not > understanding I imagine. :) Seems to be explained well in the comments? If the compilation database contains: i686-linux-android-g++

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-10-01 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: include/clang/Tooling/Tooling.h:437 @@ +436,3 @@ +/// +/// \note This will not set \c CommandLine[0] to \c InvokedAs. +void addTargetAndModeForProgramName(std::

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-09-30 Thread Eric Christopher via cfe-commits
This seems a little odd, could you explain in a bit more detail? Me not understanding I imagine. :) -eric On Wed, Sep 30, 2015, 7:48 PM Luke Zarko wrote: > zarko created this revision. > zarko added reviewers: rnk, echristo, klimek. > zarko added a subscriber: cfe-commits. > Herald added subscr

Re: [PATCH] D13318: Add a utility function to add target information to a command line

2015-09-30 Thread Eric Christopher via cfe-commits
echristo added a subscriber: echristo. echristo added a comment. This seems a little odd, could you explain in a bit more detail? Me not understanding I imagine. :) -eric http://reviews.llvm.org/D13318 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D13318: Add a utility function to add target information to a command line

2015-09-30 Thread Luke Zarko via cfe-commits
zarko created this revision. zarko added reviewers: rnk, echristo, klimek. zarko added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, klimek. This diff adds `addTargetAndModeForProgramName`, a utility function that will add appropriate `-target foo` and `--d