[PATCH] D133085: [clang] trim trailing space in format tests. NFC

2022-09-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D133085#3764067 , @inclyc wrote: > Thank you for your patience and detailed explanation! Sorry for waste your > time though ( No worries, it's definitely not a waste of time to explain this sort of stuff! :-) Reposit

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

2022-09-01 Thread YingChi Long via Phabricator via cfe-commits
inclyc added a comment. Thank you for your patience and detailed explanation! Sorry for waste your time though ( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133085/new/ https://reviews.llvm.org/D133085 __

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

2022-09-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D133085#3763233 , @inclyc wrote: > In D133085#3763198 , @ChuanqiXu > wrote: > >> Do you have commit access? If you have, I remember LLVM encourages to land >> such fixes directl

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

2022-08-31 Thread YingChi Long via Phabricator via cfe-commits
inclyc added a comment. In D133085#3763198 , @ChuanqiXu wrote: > Do you have commit access? If you have, I remember LLVM encourages to land > such fixes directly without reviewed. (+ @aaron.ballman to make sure) Thanks! I'm just not sure whether these c

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

2022-08-31 Thread YingChi Long via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5ee51e815425: [clang] trim trailing space in format tests. NFC (authored by inclyc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133085/new/ https://revie

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

2022-08-31 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added subscribers: aaron.ballman, ChuanqiXu. ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Do you have commit access? If you have, I remember LLVM encourages such fixes landed directly without review. (+ @aaron.ballman to m

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

2022-08-31 Thread YingChi Long via Phabricator via cfe-commits
inclyc created this revision. inclyc added a reviewer: clang-language-wg. Herald added a project: All. inclyc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found in https://reviews.llvm.org/D132568 Repository: rG LLVM Github Monorepo