This revision was automatically updated to reflect the committed changes.
Closed by commit rGcc4b86cfc01c: [clangd] Fix tests for implicit C function
declaration (authored by ArcsinX).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133043/new/
https:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
(And not surprising at all this regressed, the mechanism clangd is using here
is extremely fragile, we just couldn't come up with a better one :-()
Repository:
rG LLVM Github
aaron.ballman added a comment.
LGTM, but someone with more clangd experience should do the final sign off
(seeing as how I caused the issue in the first place, sorry about that!).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133043/new/
https://r
ArcsinX created this revision.
ArcsinX added reviewers: aaron.ballman, sammccall, kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
ArcsinX requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools