[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + aaronpuchert wrote: > egorzhdan wrote: > > gribozavr2 wrote: > > > egorzhdan wrote: > > > > This test was never properly passing. Because of the bu

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

aaronpuchert added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + egorzhdan wrote: > gribozavr2 wrote: > > egorzhdan wrote: > > > This test was never properly passing. Because of the bug in string > > > conver

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c0935238527: [libclang] Fix conversion from `StringRef` to `CXString` (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133009/new/ ht

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + gribozavr2 wrote: > egorzhdan wrote: > > This test was never properly passing. Because of the bug in string > > conversion, the printed comments c

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

gribozavr2 added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + egorzhdan wrote: > This test was never properly passing. Because of the bug in string > conversion, the printed comments contained the entire sou

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan added inline comments. Comment at: clang/test/Index/comment-lots-of-unknown-commands.c:3 +// XFAIL: * + This test was never properly passing. Because of the bug in string conversion, the printed comments contained the entire source file and not just

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan updated this revision to Diff 456942. egorzhdan added a comment. XFAIL a test that was accidentally passing because of incorrect behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133009/new/ https://reviews.llvm.org/D133009 Files:

[PATCH] D133009: [libclang] Fix conversion from `StringRef` to `CXString`

egorzhdan created this revision. egorzhdan added a reviewer: gribozavr2. Herald added a subscriber: arphaman. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `CXString createRef(StringRef String)` used