[PATCH] D132919: [clangd] Enable folding ranges by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc33873502003: [clangd] Enable folding ranges by default. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132919: [clangd] Enable folding ranges by default.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132919/new/ https://reviews.llvm.org/D132919 __

[PATCH] D132919: [clangd] Enable folding ranges by default.

usaxena95 updated this revision to Diff 456584. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132919/new/ https://reviews.llvm.org/D132919 Files: clang-to

[PATCH] D132919: [clangd] Enable folding ranges by default.

kadircet added a comment. In D132919#3757685 , @Trass3r wrote: > Whenever I tried this option in the past it crashed clangd. > I recommend doing some more testing before flipping the switch. we've a new implementation of folding ranges based on pseudo pa

[PATCH] D132919: [clangd] Enable folding ranges by default.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:340 desc("Enable preview of FoldingRanges feature"), -init(false), +init(true), Hidden, i think we should just retire the flag altogether, ATM this is only

[PATCH] D132919: [clangd] Enable folding ranges by default.

Trass3r added a comment. Whenever I tried this option in the past it crashed clangd. I recommend doing some more testing before flipping the switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132919/new/ https://reviews.llvm.org/D132919 ___

[PATCH] D132919: [clangd] Enable folding ranges by default.

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository