[PATCH] D132916: [clang] Explicitly set the EmulatedTLS codegen option

2022-09-13 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbfe1db4a95a: [clang] Explicitly set the EmulatedTLS codegen option. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D132916: [clang] Explicitly set the EmulatedTLS codegen option

2022-09-09 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM (I think you can call it "NFC" if there's no visible change in community; you don't have to try to account for downstream changes that might interact with it.) Repository: rG LLV

[PATCH] D132916: [clang] Explicitly set the EmulatedTLS codegen option

2022-09-09 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D132916#3781108 , @aaron.ballman wrote: > In D132916#3773791 , @mstorsjo > wrote: > >> @efriedma Does this look like what you had in mind; does it seem reasonable >> to @aaron.ballm

[PATCH] D132916: [clang] Explicitly set the EmulatedTLS codegen option

2022-09-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D132916#3773791 , @mstorsjo wrote: > @efriedma Does this look like what you had in mind; does it seem reasonable > to @aaron.ballman? This seems reasonable to me, but I leave it to @efriedma and @rjmccall for the final

[PATCH] D132916: [clang] Explicitly set the EmulatedTLS codegen option

2022-09-06 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. @efriedma Does this look like what you had in mind; does it seem reasonable to @aaron.ballman? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132916/new/ https://reviews.llvm.org/D132916 __

[PATCH] D132916: [clang] Explicitly set the EmulatedTLS codegen option

2022-08-30 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, rjmccall, efriedma. Herald added a subscriber: ormris. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. Set the EmulatedTLS option based on `Triple::hasDefaultEmulatedTLS