[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/float3.hlsl:1 +// RUN: %clang --driver-mode=dxc -Tlib_6_7 -fcgl -Fo - %s | FileCheck %s + tahonermann wrote: > Does this need to use driver mode?

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

tahonermann added inline comments. Comment at: clang/test/CodeGenHLSL/float3.hlsl:1 +// RUN: %clang --driver-mode=dxc -Tlib_6_7 -fcgl -Fo - %s | FileCheck %s + Does this need to use driver mode? That is odd for a code gen test. Repository: rG LLVM Github Mon

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

alexgatea added a comment. In D132913#3786734 , @python3kgae wrote: > In D132913#3786679 , @alexgatea > wrote: > >>> Thanks for reporting the issue. >>> But I cannot repro the fail. >>> Do you mind sharing your

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae added a comment. In D132913#3786679 , @alexgatea wrote: >> Thanks for reporting the issue. >> But I cannot repro the fail. >> Do you mind sharing your cmake command? > > Hmm, I'm just running the command in the test case: > clang --driver-mode

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

alexgatea added a comment. > Thanks for reporting the issue. > But I cannot repro the fail. > Do you mind sharing your cmake command? Hmm, I'm just running the command in the test case: clang --driver-mode=dxc -Tlib_6_7 -fcgl -Fo - clang/test/CodeGenHLSL/float3.hlsl | FileCheck clang/test/Code

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae added a comment. In D132913#3786432 , @alexgatea wrote: > This test fails because the actual output has <3 x float>* rather than ptr. > Could you please fix this test case? Thanks for reporting the issue. But I cannot repro the fail. Do you

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

alexgatea reopened this revision. alexgatea added a comment. This revision is now accepted and ready to land. This test fails because the actual output has <3 x float>* rather than ptr. Could you please fix this test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae added a comment. In D132913#3781611 , @python3kgae wrote: > In D132913#3781591 , @chapuni wrote: > >> The fix looks good. Thanks. >> >>> Is -DLLVM_ENABLE_ASSERTIONS=ON what you mean by -Asserts? >> >>

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae added a comment. In D132913#3781591 , @chapuni wrote: > The fix looks good. Thanks. > >> Is -DLLVM_ENABLE_ASSERTIONS=ON what you mean by -Asserts? > > Oh excuse me, "-Asserts" was an ancient term, "w/o assertsions" in the > autoconf age. > An

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

chapuni added a comment. The fix looks good. Thanks. > Is -DLLVM_ENABLE_ASSERTIONS=ON what you mean by -Asserts? Oh excuse me, "-Asserts" was an ancient term, "w/o assertsions" in the autoconf age. An antonym was "+Asserts". it means `LLVM_ENABLE_ASSERTIONS=ON` Repository: rG LLVM Github Mo

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae added a comment. In D132913#3781494 , @chapuni wrote: > The test fails for -Asserts. Fixed the %0 issue in https://github.com/llvm/llvm-project/commit/71fae33f5e7c1b11e32db695fd24dd50aead737c It passed locally on build with -DLLVM_ENABLE_ASS

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/float3.hlsl:4 +// Make sure float3 is not changed into float4. +// CHECK:<3 x float> @"?foo@@YAT?$__vector@M$02@__clang@@T12@@Z"(<3 x float> noundef %a) +// CHECK:%[[A_ADDR:.+]] = alloca <3 x float>, align 16

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

chapuni added a comment. The test fails for -Asserts. Comment at: clang/test/CodeGenHLSL/float3.hlsl:4 +// Make sure float3 is not changed into float4. +// CHECK:<3 x float> @"?foo@@YAT?$__vector@M$02@__clang@@T12@@Z"(<3 x float> noundef %a) +// CHECK:%[[A_ADDR:.+]] = alloca <

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rGc9d2b6b92d6c: [HLSL] Preserve vec3 for HLSL. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132913/new/ https://reviews.llvm.org/D132913 ___ c

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae updated this revision to Diff 456870. python3kgae added a comment. Switch to ImpliedByAnyOf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132913/new/ https://reviews.llvm.org/D132913 Files: clang/include/clang/Driver/Options.td cl

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

beanz added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3524 + // Preserve vec3 for HLSL. + CmdArgs.push_back("-fpreserve-vec3-type"); } Preserving vec3 is required for HLSL correctness, this shouldn't be tied to the DXC driver mode. In

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

python3kgae created this revision. python3kgae added reviewers: bogner, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Preserve vec3 for