dblaikie added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1763-1766
if (Method->isPure())
SPFlags |= llvm::DISubprogram::SPFlagPureVirtual;
else
SPFlags |= llvm::DISubprogram::SPFlagVirtual;
Seems this change means the
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc9aba6007451: [clang] Don't emit debug vtable
information for consteval functions (authored by luken-google).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1761
- if (Method->isVirtual()) {
+ if (Method->isVirtual() && !Method->isConsteval()) {
if (Method->isPure())
---
luken-google updated this revision to Diff 456641.
luken-google added a comment.
Change to method call.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132874/new/
https://reviews.llvm.org/D132874
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Cod
luken-google marked an inline comment as done.
luken-google added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1761
- if (Method->isVirtual()) {
+ if (Method->isVirtual() && !Method->isConsteval()) {
if (Method->isPure())
shafik wrote:
shafik added subscribers: aprantl, shafik.
shafik added a comment.
Maybe @aprantl you want to take a look at this.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1761
- if (Method->isVirtual()) {
+ if (Method->isVirtual() && !Method->isConsteval()) {
if (Method->isPure(
luken-google added reviewers: aaron.ballman, ilya-biryukov.
luken-google added a comment.
Note that there's still an underlying issue where the linker complains of
missing vtable information for both Base and Derived, which I'm treating as a
separate issue and will either file or de-dup against
luken-google created this revision.
Herald added a project: All.
luken-google requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://github.com/llvm/llvm-project/issues/55065
Repository:
rG LLVM Github Monorepo
https://reviews.l
