This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaa7c5c9c4e5e: [clang][Interp] Handle missing local
initializers better (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D1
shafik accepted this revision.
shafik added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132832/new/
https://reviews.llvm.org/D132832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
tbaeder updated this revision to Diff 456328.
tbaeder marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132832/new/
https://reviews.llvm.org/D132832
Files:
clang/lib/AST/Interp/ByteCodeEmitter.cpp
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:245
+
+if (!Init)
+ return false;
erichkeane wrote:
> Would be nice to test this before the work to allocate Offset?
Ah, sure. Good catch.
CHANGES SINCE LAST ACTION
h
erichkeane added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:245
+
+if (!Init)
+ return false;
Would be nice to test this before the work to allocate Offset?
Comment at: clang/lib/AST/Interp/Function.h:163
+
tbaeder updated this revision to Diff 456281.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132832/new/
https://reviews.llvm.org/D132832
Files:
clang/lib/AST/Interp/ByteCodeEmitter.cpp
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeStmtGen.cpp
clang/lib/AST
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, shafik, erichkeane, tahonermann.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is illegal in a constexpr context. We can alre
