[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rGef1bb11a34de: [clang][Parse] Fix crash when emitting template diagnostic (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D132821?vs=456389&id=456643#toc Repository: rG LLVM G

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM presuming precommit CI comes back green, but please don't forget the release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132821/new/ https://reviews.llvm.org/D132821 _

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

tbaeder updated this revision to Diff 456389. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132821/new/ https://reviews.llvm.org/D132821 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/test/Parser/cxx-concept-declaration.cpp

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Thanks for looking into this so quickly. LGTM with Aaron's suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132821/new/ https://revi

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

aaron.ballman added a comment. Please be sure to add a release note for the fix as well. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:776-779 "identifier followed by '<' indicates a class template specialization but " "%0 %select{does not refer to a templ

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

tbaeder added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:779 + "|refers to a variable template||refers to a concept|" + "refers to a concept template}1">; def err_id_after_template_in_nested_name_spec : Error< cjdb wrote: >

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:779 + "|refers to a variable template||refers to a concept|" + "refers to a concept template}1">; def err_id_after_template_in_nested_name_spec : Error< Is "concept templ

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

tbaeder added inline comments. Comment at: clang/test/Parser/cxx-concept-declaration.cpp:3 // Support parsing of concepts // Disabled for now. I guess we can drop these two lines now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The integer value of the enum here is `6`, which wasn't covered by the diagnostic.