[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-09-05 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6e7752f8e14: [clang-format] Allow `throw` to be a keyword in front of casts (authored by rymiel, committed by HazardyKnusperkeks). Repository: rG

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-09-05 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. @rymiel, please provide your name and email address for the commit message, so that we can land it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.o

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-08-29 Thread Emilia Dreamer via Phabricator via cfe-commits
rymiel updated this revision to Diff 456480. rymiel added a comment. Add extra tests for spacing options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.org/D132762 Files: clang/lib/Format/TokenAnnotator.cpp clan

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-08-29 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:10961 verifyFormat("return (my_int)aaa;"); + verifyFormat("throw (my_int)aaa;"); verifyFormat("#define x ((int)-1)"); Can we add a test that covers the setting of Space

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-08-29 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. In D132762#3756072 , @rymiel wrote: > Add a few token annotator tests Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://rev

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-08-29 Thread Emilia Dreamer via Phabricator via cfe-commits
rymiel updated this revision to Diff 456402. rymiel added a comment. Add a few token annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.org/D132762 Files: clang/lib/Format/TokenAnnotator.cpp clang/un

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-08-28 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. We should add a test case for `TT_CastRParen` in `clang/unittests/Format/TokenAnnotatorTest.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.org/D132762

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-08-27 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This at least seems to make sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.org/D132762 __

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-08-26 Thread Emilia Dreamer via Phabricator via cfe-commits
rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes `throw` more similar to `return`. Ho