Re: [PATCH] D13276: Don't adjust field offsets for external record layouts

2015-10-01 Thread Zachary Turner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249085: Don't adjust field offsets when using external record layout. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D13276?vs=36054&id=36310#toc Repository: rL LLVM http://

Re: [PATCH] D13276: Don't adjust field offsets for external record layouts

2015-10-01 Thread David Majnemer via cfe-commits
majnemer added a comment. It seems our infrastructure is not up to the task of making this testable via Clang, please commit. http://reviews.llvm.org/D13276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D13276: Don't adjust field offsets for external record layouts

2015-10-01 Thread David Majnemer via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM with a test added, see test/CodeGenCXX/override-layout.cpp for an example of how to test external record layout. http://reviews.llvm.org/D13276 ___

[PATCH] D13276: Don't adjust field offsets for external record layouts

2015-09-29 Thread Zachary Turner via cfe-commits
zturner created this revision. zturner added a reviewer: majnemer. zturner added a subscriber: cfe-commits. injecting the VBPtr always behaves this way, but injecting the VFPtr was not. This patch fixes that. http://reviews.llvm.org/D13276 Files: lib/AST/RecordLayoutBuilder.cpp Index: lib/A