This revision was automatically updated to reflect the committed changes.
Closed by commit rGd346eb7bf08c: [clang] Fix ambiguous use of
`report_fatal_error`. (authored by wyt).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132745/new/
https://review
wyt updated this revision to Diff 456311.
wyt marked an inline comment as done.
wyt added a comment.
Address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132745/new/
https://reviews.llvm.org/D132745
Files:
clang/lib/Basic/SanitizerSpec
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Basic/SanitizerSpecialCaseList.cpp:36
return SSCL;
- llvm::report_fatal_error(Error);
+ llvm::report_fatal_error(llvm::StringRef(Erro
wyt created this revision.
Herald added a project: All.
wyt requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
`report_fatal_error` is overloaded on `StringRef` and `Twine &`, therefore
passing a `std::string` argument leads to ambiguity as i
