This revision was automatically updated to reflect the committed changes.
Closed by commit rG00d648bdb5a8: [clang] Make guard(nocf) attribute available
only for Windows (authored by alvinhochun, committed by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D132661?vs=455820&id=45628
rnk accepted this revision.
rnk added a comment.
+1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132661/new/
https://reviews.llvm.org/D132661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: clang/include/clang/Basic/Attr.td:373-375
// Specifies Operating Systems for which the target applies, based off the
// OSTyp
alvinhochun updated this revision to Diff 455820.
alvinhochun added a comment.
Applied suggestions and added test coverage.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132661/new/
https://reviews.llvm.org/D132661
Files:
clang/docs/ReleaseNotes
rnk added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:373-375
// Specifies Operating Systems for which the target applies, based off the
// OSType enumeration in Triple.h
list OSes;
Do we need customcode? Can we not use the OS list her
aaron.ballman added a comment.
Thanks for this! Can you also add test coverage for the change?
Comment at: clang/include/clang/Basic/Attr.td:402
def TargetWebAssembly : TargetArch<["wasm32", "wasm64"]>;
+def TargetHasCFGuard : TargetSpec {
+ let CustomCode = [{ Target.getTrip
alvinhochun created this revision.
alvinhochun added reviewers: rnk, ajpaverd, mstorsjo, aaron.ballman.
Herald added a project: All.
alvinhochun requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Control Flow Guard is only supported on Windows
