This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc0a55121618b: [clang][deps] Minor ModuleDepCollector
refactorings NFC (authored by benlangmuir).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
benlangmuir updated this revision to Diff 455468.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132617/new/
https://reviews.llvm.org/D132617
Files:
clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h
clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp
Index:
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:277
+MDC.DirectPrebuiltModularDeps.insert(
+std::make_pair(To
benlangmuir created this revision.
benlangmuir added a reviewer: jansvoboda11.
Herald added a project: All.
benlangmuir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
- Factor module map and module file path functions out
- Use a secondary
