[PATCH] D132487: [pseudo] Placeholder disambiguation strategy: always choose second

2022-08-26 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG56c54cf66bcd: [pseudo] Placeholder disambiguation strategy: always choose second (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D132487: [pseudo] Placeholder disambiguation strategy: always choose second

2022-08-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/tool/ClangPseudo.cpp:231 + +if (Disambiguate && PrintForest) { + ForestNode *DisambigRoot = &Root; hokein wrote: > nit: we're going to print

[PATCH] D132487: [pseudo] Placeholder disambiguation strategy: always choose second

2022-08-23 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. This looks a good start! Comment at: clang-tools-extra/pseudo/tool/ClangPseudo.cpp:231 + +if (Disambiguate && PrintForest) { + ForestNode *DisambigRoot = &Root;

[PATCH] D132487: [pseudo] Placeholder disambiguation strategy: always choose second

2022-08-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Mostly mechanics here. I