[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

2022-08-23 Thread Chuanqi Xu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4332b049edf6: [docs] Add examples for printing asynchronous stack for coroutines (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHA

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

2022-08-23 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D132451#3742064 , @avogelsgesang wrote: > LGTM, thanks! > > I guess I will update this documentation with LLDB examples, as soon as > https://reviews.llvm.org/D132415 and a couple of follow-up improvements > landed. > As s

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

2022-08-23 Thread Adrian Vogelsgesang via Phabricator via cfe-commits
avogelsgesang accepted this revision. avogelsgesang added a comment. This revision is now accepted and ready to land. LGTM, thanks! I guess I will update this documentation with LLDB examples, as soon as https://reviews.llvm.org/D132415 and a couple of follow-up improvements landed. As soon as t

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

2022-08-23 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added inline comments. Comment at: clang/docs/DebuggingCoroutines.rst:619 + +.. code-block:: text + Here we can't use `.. code-block:: console` since it will meet some parsing problems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132451/new

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

2022-08-23 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 454745. ChuanqiXu added a comment. Fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132451/new/ https://reviews.llvm.org/D132451 Files: clang/docs/DebuggingCoroutines.rst Index: clang/docs/DebuggingCoroutines.rst =

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

2022-08-23 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 454744. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132451/new/ https://reviews.llvm.org/D132451 Files: clang/docs/DebuggingCoroutines.rst Index: clang/doc

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

2022-08-23 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: avogelsgesang, dblaikie, aprantl, labath, JDevlieghere. ChuanqiXu added a project: debug-info. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits