[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

2022-08-24 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D132440#3744960 , @mstorsjo wrote: >> This reverts commit eca29d4a37b8d1c93fe99be6289a60bb11cf789d >> since >> the test fails in the per-target-runtime-dir

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

2022-08-24 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. > This reverts commit eca29d4a37b8d1c93fe99be6289a60bb11cf789d > since > the test fails in the per-target-runtime-dir layout. Does that mean that the testcase ended up looking at other libraries next

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

2022-08-23 Thread Petr Hosek via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeca29d4a37b8: [Clang] Avoid using unwind library in the MSVC environment (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

2022-08-23 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 455020. phosek added a comment. Test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132440/new/ https://reviews.llvm.org/D132440 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/com

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

2022-08-23 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM. (Should we have a testcase for this, or is it trivial enough to just go as is?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132440/n

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

2022-08-23 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added a reviewer: mstorsjo. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We're seeing the following warnings with --rtlib=compiler-rt: lld-link: war